Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cage: init at 0.1.1 #67652

Merged
merged 1 commit into from Aug 30, 2019
Merged

cage: init at 0.1.1 #67652

merged 1 commit into from Aug 30, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Aug 28, 2019

Motivation for this change

Add a useful tool for Wayland based kiosks (0.1.1 is still a pre-release but for my use-case it worked well so far).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get cage to run without having xwayland on my path. (I have an X11 DE)

may want to wrap the executable with

postFixup = ''
  wrapProgram $out/bin/cage --prefix PATH "${xwayland}"
'';

@primeos
Copy link
Member Author

primeos commented Aug 29, 2019

@jonringer You're right, that might improve the user experience. I didn't add it initially as it's optional and some users might disable it on a Wayland only setup but it seems like a good default and now it can also be overwritten to null.

@jonringer
Copy link
Contributor

you could add another alias, make the default what most people would expect:

cage = callPackage ../applications/window-managers/cage { xwayland = null; };

cage-x11 = callPackage ../applications/window-managers/cage { };

although, this seems kind of backwards, generally you want the default to be untouched maybe something like this:

cage = callPackage ../applications/window-managers/cage { };

cage-x11 = callPackage ../applications/window-managers/cage { withXWayland = true; };

and just have the switch default to false withXWayland ? false

@primeos
Copy link
Member Author

primeos commented Aug 29, 2019

@jonringer oh, my comment wasn't phrased very well :o

I'm ok with enabling xwayland by default and would like to keep the implementation as is :)

@primeos primeos merged commit 69402e6 into NixOS:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants