Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yle-dl: 2.31 -> 20190614 #67656

Closed
wants to merge 5 commits into from
Closed

yle-dl: 2.31 -> 20190614 #67656

wants to merge 5 commits into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 28, 2019 •
edited

Motivation for this change

fixing @r-ryantm failed updates.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dezgeg

closure mostly due to ffmpeg + python + php

$ nix path-info -Sh ./result
/nix/store/3dnbdkxvnb46f9p4zv71xjzvj1326imw-yle-dl-20190614      413.9M

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67656
3 package were build:
python27Packages.mini-amf python37Packages.mini-amf yle-dl

@jonringer jonringer requested a review from FRidh as a code owner August 28, 2019 21:22
@ofborg ofborg bot requested a review from dezgeg August 28, 2019 21:38
@mmahut
Copy link
Member

mmahut commented Aug 30, 2019

Tests failing on aarch64-linux.

@jonringer
Copy link
Contributor Author

jonringer commented Aug 30, 2019 •
edited

Looks like endian-ness failures, since it's likely assumed-to-be-correct behavior, but fails; I'm not sure what to do but mark it as disabled for arm. Also, the project hasn't seen an update in 4 years, so I don't think opening a ticket to get arm support would be likely.

@jonringer
Copy link
Contributor Author

gone stale

@jonringer jonringer closed this Jan 9, 2020
@jonringer jonringer deleted the bump-yle-dl branch January 9, 2020 19:57
@jonringer jonringer mentioned this pull request Oct 28, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mmahut