Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latex2html: 2018 -> 2019.2 #67785

Merged
merged 1 commit into from Oct 23, 2019
Merged

latex2html: 2018 -> 2019.2 #67785

merged 1 commit into from Oct 23, 2019

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Aug 30, 2019

Motivation for this change
  • Update to latest version
  • Use GitHub instead of CTAN
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • latex2html
    • pstoimg
    • texepand (called internally by latex2html?)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yurrriq
Copy link
Member Author

yurrriq commented Aug 30, 2019 •
edited

Consider adding a test as in https://github.com/Homebrew/homebrew-core/blob/master/Formula/latex2html.rb

@yurrriq
Copy link
Member Author

yurrriq commented Oct 23, 2019 •
edited

/ping @Mic92 since I think you have write permission or at least may know someone else I should ping

@Mic92 Mic92 merged commit 671a8ae into NixOS:master Oct 23, 2019
@yurrriq
Copy link
Member Author

yurrriq commented Oct 23, 2019

Thanks!

@yurrriq yurrriq deleted the update/latex2html branch October 23, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yurrriq @Mic92