Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maturin: 0.6.1 -> 0.7.0 #67786

Merged
merged 1 commit into from Aug 30, 2019
Merged

maturin: 0.6.1 -> 0.7.0 #67786

merged 1 commit into from Aug 30, 2019

Conversation

danieldk
Copy link
Contributor

Motivation for this change

pyo3-pack has been renamed to maturin version 0.7.0. Other larger
changes are:

  • Mixed rust/python layout
  • Added PEP 517 support
  • Support settings all applicable fields from the python core
    metadata specification in Cargo.toml
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@danieldk
maturin: 0.6.1 -> 0.7.0
7e29ce8 
pyo3-pack has been renamed to maturin version 0.7.0. Other larger
changes are:

- Mixed rust/python layout
- Added PEP 517 support
- Support settings all applicable fields from the python core
  metadata specification in Cargo.toml
@Ma27 Ma27 merged commit 1a1d1bc into NixOS:master Aug 30, 2019
@Ma27
Copy link
Member

Ma27 commented Aug 30, 2019

@danieldk thanks!

@danieldk
Copy link
Contributor Author

danieldk commented Aug 31, 2019 •
edited

@Ma27 thanks for merging! I was wondering if a short blurb about the name change is necessary for the 19.09 release notes.

@danieldk danieldk deleted the maturin branch August 31, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @Ma27