Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 8478c99d0949
Choose a base ref
...
head repository: NixOS/nix
compare: 84de82100405
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Aug 28, 2019

  1. Set maximum name length in Nix

    Previously we allowed any length of name for Nix derivations. This is
    bad because different file systems have different max lengths. To make
    things predictable, I have picked a max. This was done by trying to
    build this derivation:
    
      derivation {
        name = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
        builder = "/no-such-path";
        system = "x86_64-linux";
      }
    
    Take off one a and it will not lead to file name too long. That ends
    up being 212 a’s. An even smaller max could be picked if we want to
    support more file systems.
    
    Working backwards, this is why:
    
    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-${name}.drv.chroot
    
    > 255 - 32 - 1 - 4 - 7 = 211
    matthewbauer committed Aug 28, 2019
    Copy the full SHA
    693e68e View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2019

  1. Merge pull request #3069 from matthewbauer/max-name

    Set maximum name length in Nix
    edolstra committed Aug 29, 2019
    Copy the full SHA
    84de821 View commit details
    Browse the repository at this point in the history