Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parity: 2.5.6 -> 2.5.7, parity-beta: 2.6.1 -> 2.6.2 #67755

Merged
merged 3 commits into from Sep 1, 2019
Merged

parity: 2.5.6 -> 2.5.7, parity-beta: 2.6.1 -> 2.6.2 #67755

merged 3 commits into from Sep 1, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Aug 30, 2019 •
edited

Motivation for this change

Update parity and parity-beta to the latest releases.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @akru

@ofborg ofborg bot requested a review from akru August 30, 2019 10:57
akru
akru approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@akru akru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work!

@xrelkd
Copy link
Contributor Author

xrelkd commented Aug 30, 2019

@akru You're welcome!
Hi, @worldofpeace @marsam could you review this PR? Thank you very much!

worldofpeace
worldofpeace reviewed Aug 30, 2019
View reviewed changes
pkgs/applications/blockchains/parity/parity.nix Outdated
pkgconfig cmake perl
systemd.lib systemd.dev openssl openssl.dev
];
buildInputs = [ cmake openssl perl pkgconfig systemd ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we need cmake and pkgconfig as buildInputs? Those are typically only needed during the build so they're nativeBuildInputs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also where is perl needed https://github.com/paritytech/parity-ethereum/search?q=perl&type=Code ?

@xrelkd
parity: Update buildInputs and nativeBuildInputs
b2cc915 
Move cmake and pkgconfig from buildInputs to nativeBuildInputs
Remove unneeded perl from buildInputs
@xrelkd
parity: 2.5.6 -> 2.5.7
6eee9a4
@xrelkd
parity-beta: 2.6.1 -> 2.6.2
bfe498f
@xrelkd
Copy link
Contributor Author

xrelkd commented Aug 30, 2019

@worldofpeace Thanks for the review!
buildInputs and nativeBuildInputs have been updated.

@GrahamcOfBorg build parity parity-beta

@ofborg ofborg bot requested a review from akru August 30, 2019 18:06
@xrelkd
Copy link
Contributor Author

xrelkd commented Sep 1, 2019

Hi @worldofpeace, is there any other improvement I can do for this PR?

@worldofpeace
Copy link
Contributor

Hi @worldofpeace, is there any other improvement I can do for this PR?

Seeing if it can be integrated now. Thanks for the reminder.

worldofpeace
worldofpeace approved these changes Sep 1, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Still builds.

@worldofpeace worldofpeace merged commit 5d10eab into NixOS:master Sep 1, 2019
@xrelkd xrelkd deleted the update/parity branch September 1, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@akru akru Awaiting requested review from akru

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @worldofpeace @akru