Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 60.8.0 -> 68.0 #67754

Merged
merged 2 commits into from Sep 6, 2019
Merged

thunderbird, thunderbird-bin: 60.8.0 -> 68.0 #67754

merged 2 commits into from Sep 6, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Aug 30, 2019

Motivation for this change

Many updates and fixes.

https://www.thunderbird.net/en-US/thunderbird/68.0/releasenotes/

Unsolved problem: when you upgrade from older version, the old profile is ignored and a new profile is created.
Workaround: launch Thunderbird with -P option and select the old profile. This is only needed for the first time.
https://bugzilla.mozilla.org/show_bug.cgi?id=1542025

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @nbp @edolstra @Fuuzetsu

@ofborg ofborg bot requested review from edolstra, Fuuzetsu and nbp August 30, 2019 10:45
@vcunat
Copy link
Member

vcunat commented Aug 30, 2019 •
edited

Isn't that the same problem as we patched in Firefox? (Perhaps it might even apply the same?)

@taku0
Copy link
Contributor Author

taku0 commented Aug 31, 2019 •
edited

Isn't that the same problem as we patched in Firefox? (Perhaps it might even apply the same?)

Applied the fix.

#61980

@mweinelt
Copy link
Member

mweinelt commented Sep 4, 2019

I've tested this changeset, I started Thunderbird via ./thunderbird -P and I can still up/downgrade to/from 60.8.0. All in all it seem to work well.

@vcunat

This comment has been minimized.

Sign in to view
@vcunat
Copy link
Member

vcunat commented Sep 5, 2019 •
edited

Oh, I missed that you applied the workaround. I (now) do not need to use the -P step for thunderbird (without -bin). I suspect thunderbird-bin requires it in my case because it's really considered a different version?

@taku0
Copy link
Contributor Author

taku0 commented Sep 5, 2019

I have applied SNAP_NAME trick to both thunderbird and thunderbird-bin, though I didn't tested it works.

vcunat added a commit that referenced this pull request Sep 6, 2019
@vcunat
thunderbird: 60.8.0 -> 60.9.0
0d79dec 
I know there's 68.0 already #67754, but let's be conservative on 19.03
and remain on the older Thunderbird branch for a bit longer.
vcunat
vcunat approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me.

vcunat added a commit that referenced this pull request Sep 6, 2019
@vcunat
Merge #67754: thunderbird*: 60.8.0 -> 68.0
0b0fdde
@vcunat vcunat merged commit ac84c1e into NixOS:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @vcunat @mweinelt