Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hydra-cli: init at 0.2.0 #67680

Merged
merged 1 commit into from Sep 21, 2019
Merged

hydra-cli: init at 0.2.0 #67680

merged 1 commit into from Sep 21, 2019

Conversation

gilligan
Copy link
Contributor

Adding hydra-cli

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from nlewo August 29, 2019 10:33
@nlewo
Copy link
Member

nlewo commented Aug 29, 2019

Thanks for this PR :)

Why are you not using carnix?

@gilligan
Copy link
Contributor Author

Thanks for this PR :)

Why are you not using carnix?

Because it doesn't work reliably. hydra-cli doesn't even build anymore with updated dependencies. I think hydra-cli itself might have to switch away so i prefer to not use it for nixpkgs either.

@gilligan
Copy link
Contributor Author

@mmahut thanks a lot for your review. much appreciated :)

@Ma27 Ma27 merged commit a141d29 into NixOS:master Sep 21, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 21, 2019

@gilligan thanks!

@nlewo
Copy link
Member

nlewo commented Oct 9, 2019

hm, it seems cargoSha256 was no longer correct when Hydra built it: https://hydra.nixos.org/build/102205464/nixlog/2
I don't really know how this possible. Did the rust community update in place a dependency?
Anyway, i'm submitting a PR with the correct hash.

@nlewo nlewo mentioned this pull request Oct 9, 2019
Merged
10 tasks
@Ma27
Copy link
Member

Ma27 commented Oct 9, 2019

Did anything in cargo vendor change? (IIRC that already happened several months ago when we had to fix all cargo hashes).

@nlewo
Copy link
Member

nlewo commented Oct 9, 2019

@Ma27 I don't think so.

nlewo added a commit to nlewo/nixpkgs that referenced this pull request Oct 9, 2019
@nlewo
hydra-cli: update the cargoSha256 hash
0a7c50e 
This might be related to the way cargo fetches sources since the old
hash still works on the original PR (before being rebased onto master by
the merge action).
See
- NixOS#67680
- https://hydra.nixos.org/build/102205464/nixlog/2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@Ma27 Ma27 Ma27 approved these changes

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gilligan @nlewo @Ma27 @mmahut