Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

particl-core: 0.17.1.2 -> 0.18.1.3 #67799

Closed
wants to merge 1 commit into from
Closed

particl-core: 0.17.1.2 -> 0.18.1.3 #67799

wants to merge 1 commit into from

Conversation

demyanrogozhin
Copy link
Member

Motivation for this change

Particl blockchain planned hardfork happened at 2019.07.16, minimal compatible version of Particl Core is v0.18.0.10.
For details see:
https://particl.news/hardfork-announcement-ringct-bulletproofs-ready-for-part-july-9df87794bd42

Changelog:
https://github.com/particl/particl-core/blob/0.18/doc/release-notes-particl.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@demyanrogozhin demyanrogozhin force-pushed the particl-core-0.18.1.3 branch 2 times, most recently from 01c3440 to cf6d802 Compare August 31, 2019 18:11
@demyanrogozhin
Copy link
Member Author

Closing for now as this PR is provides upgrade to outdated version (mainline Particl-Core is v0.19 now). Will re-open and update if someone express interest in decentralized private p2p market on blockchain.
But as for now I think it would better simply remove this from nixpkgs and add to my personal NUR (which I'm going to do).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@demyanrogozhin @disassembler