Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomacs: build using Qt mkDerivation (+ translations) #67767

Merged
merged 2 commits into from Sep 1, 2019
Merged

nomacs: build using Qt mkDerivation (+ translations) #67767

merged 2 commits into from Sep 1, 2019

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Aug 30, 2019

nomacs fails to run on unstable with the following error:

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Using the Qt mkDerivation fixes this.

This PR also enables translations, which I can split off if necessary.

Motivation for this change

Further to #65399

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) (322.2M -> 362.4M)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ahmedtd

worldofpeace
worldofpeace suggested changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove wrapGAppsHook then.

Though I'm seeing it adding gsettings-desktop-schemas though I don't see any bindings to gsettings.

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Aug 31, 2019

We should remove wrapGAppsHook then.

Done

Though I'm seeing it adding gsettings-desktop-schemas though I don't see any bindings to gsettings.

You're right, there are no schemas provided, so it should be safe to remove gsettings-desktop-schemas.

Building and running works fine without it.

worldofpeace
worldofpeace approved these changes Sep 1, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified it was wrapped.

@worldofpeace worldofpeace merged commit b797fbc into NixOS:master Sep 1, 2019
@B4dM4n B4dM4n deleted the nomacs-wrap-qt branch September 1, 2019 11:43
@B4dM4n B4dM4n restored the nomacs-wrap-qt branch September 1, 2019 13:28
@B4dM4n B4dM4n mentioned this pull request Sep 1, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @worldofpeace