Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

falkon: use qt5's mkDerivation #67669

Merged
merged 1 commit into from Aug 29, 2019
Merged

falkon: use qt5's mkDerivation #67669

merged 1 commit into from Aug 29, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Aug 29, 2019 •
edited

Motivation for this change

See #65399

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files (runs inside nix-shell --pure -p)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ttuegel @peterhoeg

@ofborg ofborg bot requested a review from peterhoeg August 29, 2019 07:49
@teto
Copy link
Member

teto commented Aug 29, 2019

tested with nix-review and worked

@ofborg ofborg bot requested a review from peterhoeg August 29, 2019 08:51
worldofpeace
worldofpeace approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and executes. Verified the binary was wrapped.

@worldofpeace worldofpeace changed the title falkon: use mkDerivation falkon: use qt5's mkDerivation Aug 29, 2019
@worldofpeace worldofpeace merged commit 484a541 into NixOS:master Aug 29, 2019
@rnhmjoj rnhmjoj deleted the falkon branch September 14, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @teto @peterhoeg @worldofpeace