Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Softmaker Office and FreeOffice #67775

Merged
merged 3 commits into from Sep 15, 2019
Merged

Add Softmaker Office and FreeOffice #67775

merged 3 commits into from Sep 15, 2019

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Aug 30, 2019 •
edited

Motivation for this change

Adds two office suites. FreeOffice is freeware, whereas SoftMaker Office requires a purchased license. This PR replaces #67105.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@danieldk
softmaker-office: init at 970
97390d6
@danieldk
freeoffice: init at 966
11184de
@danieldk
freeoffice: 966 -> 970
accc62a 
Changes:

- Adds support for saving documents to the DOC, XLS, and PPT formats.
- TextMaker adds support for saving to the OpenDocument format.
- Adds a dark mode.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/54

@romildo romildo self-requested a review September 13, 2019 14:36
romildo
romildo approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Looks good to me.

@romildo romildo merged commit a85b938 into NixOS:master Sep 15, 2019
@danieldk
Copy link
Contributor Author

@romildo Thanks for merging this! Any chance that this could also be added to the release-19.09 branch, since there is no effect on other packages and it would be nice to have the additional office suite choices.

@romildo
Copy link
Contributor

romildo commented Sep 15, 2019

@romildo Thanks for merging this! Any chance that this could also be added to the release-19.09 branch, since there is no effect on other packages and it would be nice to have the additional office suite choices.

@lheckemann What do you think about merging this to release-19.09?

@lheckemann
Copy link
Member

Soft -1. Especially for packages without modules, getting them from the unstable channel should be fairly easy on 19.09 (e.g. nix-env -f channel:nixos-unstable -iA freeoffice). If there's a good reason why that won't work, you can convince me otherwise though :)

@danieldk
Copy link
Contributor Author

Fair enough! I was a bit worried about the closure size (and thus leading to a lot of duplicated packages between 19.09 and unstable), but the closure of Softmaker/FreeOffice is actually quite lean (mostly glibc, libstdc++, and X11 libs).

@danieldk danieldk deleted the softmaker-office branch September 30, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romildo romildo romildo approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @nixos-discourse @romildo @lheckemann