Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hakyll-images: unmark as broken #67776

Merged
merged 1 commit into from Aug 30, 2019
Merged

haskellPackages.hakyll-images: unmark as broken #67776

merged 1 commit into from Aug 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 30, 2019

Motivation for this change

Builds and works fine now

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti

@ghost ghost requested a review from basvandijk as a code owner August 30, 2019 16:03
peti
peti requested changes Aug 30, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target the haskell-updates branch with this PR.

@ghost ghost changed the base branch from master to haskell-updates August 30, 2019 16:58
@ghost
Copy link
Author

ghost commented Aug 30, 2019

@peti Done, thanks

@peti peti merged commit 6580260 into NixOS:haskell-updates Aug 30, 2019
@ghost
Copy link
Author

ghost commented Aug 30, 2019

@peti Thank you!

@ghost ghost deleted the hakyll-images branch August 30, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@peti