python uvloop libary: updating, 0.12.2 to 0.13.0 #67735
Conversation
|
@GrahamcOfBorg build python3Packages.uvloop |
| }; | ||
|
|
||
| buildInputs = [ libuv ]; | ||
|
|
||
| # The flake8 config file is not bundled with the pypi release, but |
There was a problem hiding this comment.
Why not use a github release https://github.com/MagicStack/uvloop/releases?
There was a problem hiding this comment.
I was initially considering it, but then I thought it might be preferable to minimize the changes to the derivation. What do you think?
There was a problem hiding this comment.
if tests are missing it is fine to make the switch and use the GitHUb release. Note, however, that flake8 tests are not interesting for us. It's just linting and style.
There was a problem hiding this comment.
Yeah, I'm also a bit torn. I was kinda just trying to keep the changes as minimal as possible and stay close to upstream, since I'm not the maintainer. Would you prefer us to try and blacklist this test?
There was a problem hiding this comment.
unit tests we should try to keep, but these linting/style tests can indeed be blacklisted.
cc @costrouc
There was a problem hiding this comment.
Alright, so for now I just plainly switched to removing this particular test-file.
Regarding using the github release, I briefly tried it out, but aside from requiring more changes to the derivation, there are some issues with one of the setuptools build_ext stages like error: don't know how to compile C/C++ code on platform 'posix' with '<distutils.unixccompiler.UnixCCompiler object at 0x7ffff71a8a90>' compiler) - which is odd, as some native compilation steps seem to work just fine. Maybe somebody else knows. (cc @worldofpeace)
So, maybe it's fine to just leave it using fetchPypi and ditch the file.
|
you need to add |
|
@disassembler: Could you please briefly explain to me why this would be required? I have not seen this being used in python modules derivations yet and also don't run darwin, so I don't really understand what it would do in this case. |
|
because apple, lol. See the file not found errors at https://logs.nix.ci/?key=nixos/nixpkgs.67735&attempt_id=d3a6510b-d8f4-458b-94ed-a424b4ea4c53 |
|
@disassembler: Oh, thanks. I assume that this issue must have happened before as well. I will try to include it a bit later. |
|
@GrahamcOfBorg build python3Packages.uvloop |
1 similar comment
|
@GrahamcOfBorg build python3Packages.uvloop |
|
We need to correct the commit msg to |
|
Can you do this when squashing before merge, or should I squash and force push? |
Squash/fixup and force push should be fine. Be sure to document the actual changes for the update in the body. |
|
@disassembler: Hm, the darwin build timed out running the tests. Should we just give it another go? |
|
@GrahamcOfBorg build python3Packages.uvloop |
* As mentioned in NixOS#67492 the build was broken after an update of openssl versions. * Fixes a flake8 unit-test case that requires a flake8 config which is not shipped with the distribution. * Fixes build on darwin.
d-goldin
force-pushed
the
d-goldin/bump_uvloop
branch
from
ef9bd59
to
642382f
Compare
* As mentioned in NixOS#67492 the build was broken after an update of openssl versions. * Fixes a flake8 unit-test case that requires a flake8 config which is not shipped with the distribution. * Fixes build on darwin. (cherry picked from commit a88976d)
Motivation for this change
As mentioned in #67492
the build is currently broken after an update of openssl versions.
The updated version fixes the issue but requires an additional
patch adding a flake8 file as its needed by a test-case but is not
shipped in released versions.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @costrouc