Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anki: 2.1.11 -> 2.1.14 #67738

Merged
merged 2 commits into from Aug 31, 2019
Merged

anki: 2.1.11 -> 2.1.14 #67738

merged 2 commits into from Aug 31, 2019

Conversation

averelld
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut
Copy link
Member

mmahut commented Aug 30, 2019

@GrahamcOfBorg build anki

@mmahut
Copy link
Member

mmahut commented Aug 30, 2019

Fails to rebuild on darwin:

/private/tmp/nix-build-qtwebengine-5.11.3.drv-0/qtwebengine-everywhere-src-5.11.3/src/3rdparty/chromium/base/mac/sdk_forward_declarations.h:51:3: error: redefinition of enumerator 'NSSpringLoadingHighlightEmphasized'
  NSSpringLoadingHighlightEmphasized```

@averelld
Copy link
Contributor Author

Seems unrelated, that platform has been broken since #50379. It was merged regardless for some reason.

@mmahut
Copy link
Member

mmahut commented Aug 30, 2019

@NixOS/darwin-maintainers do you mind having a look? If it is failing and we cannot fix it, we must exclude it.

Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested sync, reviews, audio playback on NixOS x86_64

@Profpatsch
Copy link
Member

Cool, thanks.

@Profpatsch Profpatsch merged commit 560ce2a into NixOS:master Aug 31, 2019
disassembler added a commit that referenced this pull request Aug 31, 2019
* upstream/master:
  vimPlugins: update (#67823)
  mattermost-desktop: 4.2.0 -> 4.2.3 (#67717)
  lightspark: init at 0.8.1 (#67425)
  anki: 2.1.11 -> 2.1.14 (#67738)
  nixos/{namecoind,bitcoind}: removing the altcoin prefix
  rust-cbindgen: 0.8.7 -> 0.9.0
@averelld averelld deleted the anki-upgrade branch August 31, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants