Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ground track analysis #2302

Merged
merged 27 commits into from
Sep 1, 2019
Merged

Conversation

eggrobin
Copy link
Member

No description provided.

astronomy/orbit_ground_track.hpp Outdated Show resolved Hide resolved
astronomy/orbit_ground_track.hpp Show resolved Hide resolved
}

// The resulting angle is not normalized.
template<typename Iterator, typename Inertial>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this taking an Iterator (which could be anything) and not a frame (where the iterator would be DiscreteTrajectory<Frame>::Iterator)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deduction.

astronomy/orbit_ground_track_body.hpp Outdated Show resolved Hide resolved

// Represents the interval [min, max]; T must be an ordered affine space.
template<typename T>
struct Interval {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer it if this was a class and min and max were selectors. You should really not shoot directly at min and max.

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe later.

Sorry, something went wrong.

astronomy/orbit_analysis_test.cpp Outdated Show resolved Hide resolved
@pleroy pleroy added the LGTM label Aug 31, 2019
@eggrobin
Copy link
Member Author

retest this please

@eggrobin eggrobin merged commit b66487a into mockingbirdnest:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants