-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ground track analysis #2302
Ground track analysis #2302
Conversation
Time year; | ||
}; | ||
|
||
template<typename PrimaryCentred, typename Inertial> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment this function.
} | ||
|
||
// The resulting angle is not normalized. | ||
template<typename Iterator, typename Inertial> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this taking an Iterator
(which could be anything) and not a frame (where the iterator would be DiscreteTrajectory<Frame>::Iterator
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deduction.
|
||
// Represents the interval [min, max]; T must be an ordered affine space. | ||
template<typename T> | ||
struct Interval { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer it if this was a class and min
and max
were selectors. You should really not shoot directly at min
and max
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe later.
retest this please |
No description provided.