Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errbot: 5.2.0 -> 6.1.1 #67781

Merged
merged 1 commit into from Dec 15, 2019
Merged

errbot: 5.2.0 -> 6.1.1 #67781

merged 1 commit into from Dec 15, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 30, 2019 •
edited

Motivation for this change

fixing @r-ryantm updates

Also:

  • enabled tests
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz @globin

nix-review pr 67781
...
[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67781
1 package were build:
errbot

$ nix path-info -Sh ./result
/nix/store/j4w4z2pg2m50wzbmfqfc94lvqsmw1lwd-errbot-6.1.1         140.4M
$ nix path-info -Sh ./result
/nix/store/ijqcs0bygkpqipf1wgsfkspd0d256w02-errbot-5.2.0         132.5M

@jonringer
Copy link
Contributor Author

noticed that installing the pyside extra included the qt4 closure... removed it to save 600MB

@ofborg ofborg bot requested review from fpletz and globin August 30, 2019 17:43
@mmahut
Copy link
Member

mmahut commented Aug 31, 2019

Do you mind resolving the conflict please?

@mmahut
Copy link
Member

mmahut commented Aug 31, 2019

@GrahamcOfBorg build errbot

@fpletz
Copy link
Member

fpletz commented Dec 15, 2019

Rebased onto current master and fixed the conflict.

@fpletz fpletz merged commit b973f7b into NixOS:master Dec 15, 2019
@jonringer jonringer deleted the bump-errbot branch December 15, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @mmahut @fpletz