Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kinetic-cpp-client: use openssl_1_0_2 #67676

Merged
merged 1 commit into from Aug 30, 2019
Merged

kinetic-cpp-client: use openssl_1_0_2 #67676

merged 1 commit into from Aug 30, 2019

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Aug 29, 2019

Motivation for this change

c18167c broke build of kinetic-cpp-client.
Perhaps an upgrade of kinetic-cpp-client could provide support for openssl v1.1, I don't know. But at least I know this version builds with v1.0.2.

@GrahamcOfBorg build kinetic-cpp-client

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @globin

@globin
Copy link
Member

globin commented Aug 29, 2019

Mind that openssl 1.0.2 is EOL at the end of the year, we should refrain from using it as much as possible.

@johanot johanot mentioned this pull request Aug 29, 2019
Merged
10 tasks
@globin
Copy link
Member

globin commented Aug 30, 2019

I'm merging this for now to not block the ceph upgrade!

@globin globin merged commit 3f8ac3f into NixOS:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johanot @globin