Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hlint: refresh ghc-lib-parser override and jailbreak #67678

Closed
wants to merge 1 commit into from
Closed

hlint: refresh ghc-lib-parser override and jailbreak #67678

wants to merge 1 commit into from

Conversation

mdorman
Copy link
Contributor

@mdorman mdorman commented Aug 29, 2019

Motivation for this change

Get hlint building again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti

@peti
Copy link
Member

peti commented Aug 29, 2019

The PR description "get hlint building again" surprises me. I believe hlint builds just fine: https://hydra.nixos.org/job/nixpkgs/haskell-updates/haskellPackages.hlint.x86_64-linux. Are you having trouble using the package as-is?

@cdepillabout
Copy link
Member

I took a look at this as well, and I am not sure why the override and jailbreak are needed.

It looks like the most recent release of hlint (2.2.2) still uses ghc-lib-parser ==8.8.0.20190723, so I think the current configuration for hlint should be kept.

@mdorman
Copy link
Contributor Author

mdorman commented Aug 29, 2019

Ah, I created the patch before 30a31cc went in, and found that just updating to the based-on-8.8.1 release of ghc-lib-parser worked fine.

I agree, in light of bringing back the version hlint actually wants, this isn't needed.

@mdorman mdorman closed this Aug 29, 2019
@mdorman mdorman deleted the hlint-fix branch August 29, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
0.kind: enhancement 6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdorman @peti @cdepillabout