Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh-history: init at unstable-2019-08-29 #67670

Merged
merged 8 commits into from Oct 16, 2019
Merged

zsh-history: init at unstable-2019-08-29 #67670

merged 8 commits into from Oct 16, 2019

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Aug 29, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented Aug 29, 2019

@GrahamcOfBorg eval

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/58

JohnAZoidberg
JohnAZoidberg reviewed Sep 27, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with our go infrastructure, but I think you shouldn't have to do some manual steps.

pkgs/shells/zsh/zsh-history/default.nix Outdated Show resolved Hide resolved
pkgs/shells/zsh/zsh-history/default.nix Outdated Show resolved Hide resolved
@kampka
Copy link
Contributor Author

kampka commented Sep 27, 2019

@JohnAZoidberg
Thank you for reviewing!
I addresses all your concerns I believe, if you want to have a second look.

JohnAZoidberg
JohnAZoidberg requested changes Sep 28, 2019
View reviewed changes
pkgs/shells/zsh/zsh-history/default.nix Show resolved Hide resolved
pkgs/shells/zsh/zsh-history/default.nix Outdated Show resolved Hide resolved
pkgs/shells/zsh/zsh-history/default.nix Outdated Show resolved Hide resolved
pkgs/shells/zsh/zsh-history/default.nix Outdated Show resolved Hide resolved
pkgs/shells/zsh/zsh-history/default.nix Outdated Show resolved Hide resolved
pkgs/shells/zsh/zsh-history/default.nix Outdated Show resolved Hide resolved
@kampka
Copy link
Contributor Author

kampka commented Oct 5, 2019

@JohnAZoidberg Any chance we can continue this soonish? :)

@ofborg ofborg bot requested a review from kalbasit October 7, 2019 08:26
@kampka @worldofpeace
Update pkgs/shells/zsh/zsh-history/default.nix
5ddfcc1 
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
@worldofpeace
Copy link
Contributor

When I use it I get this error

Error: toml: cannot load TOML value of type map[string]interface {} into a Go primitive (string-like)

Otherwise I believe everything's fine.

@kampka
Copy link
Contributor Author

kampka commented Oct 12, 2019

@worldofpeace looks like you found an bug that's triggered when generating the config file on first run.
Sent a patch upstream, will update this branch once it's merged.

@worldofpeace
Copy link
Contributor

@worldofpeace looks like you found an bug that's triggered when generating the config file on first run.
Sent a patch upstream, will update this branch once it's merged.

It's also acceptable to fetch the patch with fetchpatch from https://patch-diff.githubusercontent.com/raw/b4b4r07/history/pull/10.patch.

@kampka
Copy link
Contributor Author

kampka commented Oct 12, 2019 via email •
edited

@kampka kampka mentioned this pull request Oct 13, 2019
Closed
10 tasks
@kampka
Copy link
Contributor Author

kampka commented Oct 15, 2019

@worldofpeace backported the patch from upstream
If this fixes the issue for you I think this should be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@JohnAZoidberg JohnAZoidberg Awaiting requested review from JohnAZoidberg

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kampka @nixos-discourse @worldofpeace @teto @JohnAZoidberg