Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Btrfs dedupe #67705

Closed
wants to merge 1 commit into from
Closed

Remove Btrfs dedupe #67705

wants to merge 1 commit into from

Conversation

ikervagyok
Copy link
Contributor

Motivation for this change

btrfs-dedupe isn't maintained for a while now, bees is an alternative that seems to be working and is already integrated into the module system.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

Could you squash your commits and add a changelog entry with a proposed migration path?

@markuskowa
Copy link
Member

As an alternative the package could be also marked as broken.

@ikervagyok ikervagyok marked this pull request as ready for review February 21, 2020 16:23
@ikervagyok ikervagyok mentioned this pull request Mar 9, 2020
Merged
@marsam
Copy link
Contributor

marsam commented Mar 13, 2020

addressed by #82124

@marsam marsam closed this Mar 13, 2020
@ikervagyok ikervagyok deleted the btrfs-dedupe branch March 13, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 9.needs: changelog 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ikervagyok @adisbladis @markuskowa @marsam