Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.phonenumbers: 8.10.16 -> 8.10.17 #67752

Merged
merged 1 commit into from Sep 2, 2019

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Aug 30, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
matrix-synapse executables seem to work

[5 built, 44 copied (58.7 MiB), 10.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67752
3 package were build:
matrix-synapse python27Packages.phonenumbers python37Packages.phonenumbers

@worldofpeace worldofpeace changed the title python: phonenumbers: 8.10.16 -> 8.10.17 pythonPackages.phonenumbers: 8.10.16 -> 8.10.17 Sep 2, 2019
@worldofpeace worldofpeace merged commit 58eb9a2 into NixOS:master Sep 2, 2019
@fadenb fadenb deleted the python_phonenumbers branch November 14, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants