[DRAFT] Allow PULLUP=1 as a valid int attr value to re-enable yosys 0.9 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 0.9 synth w/ iCEBreaker UART board def.
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
- Coverage 80.4% 80.34% -0.07%
==========================================
Files 34 34
Lines 5518 5520 +2
Branches 1197 1198 +1
==========================================
- Hits 4437 4435 -2
- Misses 936 938 +2
- Partials 145 147 +2
Continue to review full report at Codecov.
|
|
Fixed in master. |
|
Great! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having trouble getting the iCEBreaker UART to work with yosys 0.9 (PULLUP="1" causes downstream issue). See this brief thread for the discussion with @daveshah1 for context. Specifically, I'm trying to change the
PULLUP="1"to a numericPULLUP=1in the nmigen-board definition.Easy. But, unless I make the associated change to how nMigen handles
Attrs(this pull request proposal), I continue to get the string.repr, and not the numeric value in the.ilfile.Would love your feedback on this change. Should make it possible to pass a numeric value for the PULLUP attribute to Yosys 0.9 and nextpnr. It may be the completely wrong place to address the challange, happy to learn!
This change would make 1 (int) a valid attr value, which means the
test_build_dsl.test_wrong_value test, which guards against1being valid, would no longer be needed.The fact that I'm rendering a known test obsolete makes be suspicious that this may not be the right way of going addressing the root cause of the problem at all ;-)
Please view this pull request as a discussion starter. Appreciate guidance on how to solve this issue and how I can best help.