Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove altcoins set and create blockchains section #67687

Merged
merged 4 commits into from Aug 29, 2019

Conversation

jb55
Copy link
Contributor

@jb55 jb55 commented Aug 29, 2019

Motivation for this change

Altcoins was always a strange name for this type of software. Bitcoin was categorized as an "altcoin" which is pretty confusing/strange. See #25025 for why blockchains was chosen, but happy to hear alternatives.

This removes the altcoins set and splays them into all-packages in a new blockchains section.

Fixes #25025

Things
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut @chris-martin

Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
This is no longer needed

Signed-off-by: William Casarin <jb55@jb55.com>
@mmahut
Copy link
Member

mmahut commented Aug 29, 2019

Thank you for the effort! This looks good to me, if ofborg doesn't complain I think we can merge it.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (no rebuilds)
diff LGTM

[1 built, 50 copied (1179.0 MiB), 257.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67687
5 package are marked as broken and were skipped:
dcrd dcrwallet freicoin pivx pivxd

24 package were build:
aeon bitcoin-abc bitcoin-classic bitcoin-unlimited bitcoind bitcoind-abc bitcoind-classic bitcoind-unlimited btc1 btc1d dashpay dero dogecoin dogecoind go-ethereum-classic litecoin litecoind masari mist namecoin namecoind sumokoin wownero zcash

@mmahut mmahut merged commit bc08b42 into NixOS:master Aug 29, 2019
@mmahut
Copy link
Member

mmahut commented Aug 30, 2019

@jb55 one more thing I forgot - do you mind to put this change in nixos/doc/manual/release-notes/rl-1909.xml?

jb55 added a commit to jb55/nixpkgs that referenced this pull request Sep 1, 2019
Release notes for NixOS#67687 (bc08b42) [1]
Related issue: NixOS#25025 [2]

[1] NixOS#67687
[2] NixOS#25025

Suggested-by: @mmahut
Signed-off-by: William Casarin <jb55@jb55.com>
@jb55 jb55 mentioned this pull request Sep 1, 2019
10 tasks
@jb55
Copy link
Contributor Author

jb55 commented Sep 1, 2019

@mmahut: done: #67892

let me know if that looks right

@mmahut
Copy link
Member

mmahut commented Sep 2, 2019

@jb55 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganization of "altcoins"
3 participants