Remove support for stub-* files in the manifest #18746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
approved these changes
Aug 29, 2019
|
Thanks for the review, @jgraham. When verifying that an incremental update would work I found that it didn't and pushed some changes to deal with that. Is that fine, or should we bump the manifest version? |
wpt-pr-bot
added
infra
manifest
wptrunner
|
Oh we don't handle a whole test type being dropped. Hmm, seems a shame to leave that code in until we next bump the manifest version, but maybe not too bad. Add a comment indicating it should be removed when the manifest version is higher than whatever the current version is. @gsnedders may disagree of course. |
gsnedders
reviewed
Sep 3, 2019
The manifest support was added in commit 2650e63, ensuring they aren't treated as tests. Part 2 of web-platform-tests/rfcs#27.
foolip
force-pushed
the
foolip/stub-tools
branch
from
893679c
to
04fbed9
Compare
|
@gsnedders do you want to review again? |
jgraham
approved these changes
Sep 6, 2019
|
@gsnedders merging now, please comment after the fact if you don't like what I did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manifest support was added in commit 2650e63,
ensuring they aren't treated as tests.
Part 2 of web-platform-tests/rfcs#27.