Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "python37Packages.aiorpcx: 0.17.0 -> 0.18.3" #63671

Merged
merged 1 commit into from Jun 23, 2019
Merged

Revert "python37Packages.aiorpcx: 0.17.0 -> 0.18.3" #63671

merged 1 commit into from Jun 23, 2019

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Jun 22, 2019 •
edited

This reverts commit 299996b.

Motivation for this change

electrum no longer builds as it has not yet released an update that supports version 0.18, and is the only package that depends on aiorpcx.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arcnmx arcnmx requested a review from FRidh as a code owner June 22, 2019 20:25
@arcnmx
Revert "python37Packages.aiorpcx: 0.17.0 -> 0.18.3"
d854b86 
This reverts commit 299996b.
electrum, the only dependent package, failed to build with this.
@FRidh FRidh merged commit 7d07263 into NixOS:master Jun 23, 2019
@arcnmx arcnmx deleted the aiorpcx-downgrade branch June 23, 2019 07:00
@delroth
Copy link
Contributor

delroth commented Jun 23, 2019

We could consider backporting spesmilo/electrum@41f160d until electrum gets a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arcnmx @delroth @FRidh