Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rambox-pro: 1.1.2 -> 1.1.4 #63669

Merged
merged 1 commit into from Aug 1, 2019
Merged

rambox-pro: 1.1.2 -> 1.1.4 #63669

merged 1 commit into from Aug 1, 2019

Conversation

cawilliamson
Copy link
Member

Motivation for this change

Upgraded the rambox-pro package I previously created from 1.1.2 to 1.1.4 and added necessary changes to accomplish this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cawilliamson
rambox-pro: 1.1.2 -> 1.1.4
a8ad083 
Upgraded the rambox-pro package I previously created from 1.1.2 to 1.1.4 and added necessary changes to accomplish this.
@worldofpeace
Copy link
Contributor

This should be good to merge, but I'm not sure it's ok if the source repo is gone...

@globin globin merged commit fe39200 into NixOS:master Aug 1, 2019
@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 2, 2019 •
edited

but I'm not sure it's ok if the source repo is gone...

By that I meant it says unknown repository for where the commit is from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cawilliamson @worldofpeace @globin