Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk8: swtich darwin to adoptopenjdk8 at jdk8u212-b04 #63667

Closed
wants to merge 1 commit into from
Closed

openjdk8: swtich darwin to adoptopenjdk8 at jdk8u212-b04 #63667

wants to merge 1 commit into from
+165 −17

Conversation

gleber
Copy link
Contributor

@gleber gleber commented Jun 22, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 10.rebuild-linux: 11-100 labels Jun 22, 2019
@risicle
Copy link
Contributor

risicle commented Jun 23, 2019

Build of adoptopenjdk-openj9-bin-8 fails for me on macos 10.13:

building '/nix/store/56a2zn6v30vyknpp4f6afnrv921309dn-OpenJDK8U-jdk_x64_mac_openj9_8u212b04_openj9-0.14.2.tar.gz.drv'...

trying https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u212-b04_openj9-0.14.2/OpenJDK8U-jdk_x64_mac_openj9_8u212b04_openj9-0.14.2.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   649    0   649    0     0   1690      0 --:--:-- --:--:-- --:--:--  1694
100  108M  100  108M    0     0   582k      0  0:03:10  0:03:10 --:--:-- 1161k
building '/nix/store/pfh4bljwpjq08wiy7cc90db04wsw9mmz-adoptopenjdk-openj9-bin-8.0.212.drv'...
unpacking sources
unpacking source archive /nix/store/6hjjbvw9lyh8b8s6vbk82q94nds03ywf-OpenJDK8U-jdk_x64_mac_openj9_8u212b04_openj9-0.14.2.tar.gz
source root is jdk8u212-b04
setting SOURCE_DATE_EPOCH to timestamp 1558507151 of file jdk8u212-b04/Contents/Home/jre/lib/server/libjvm.dylib
patching sources
configuring
no configure script, doing nothing
building
no Makefile, doing nothing
installing
ln: failed to create symbolic link '/nix/store/1dicsm5jvgwsvjyw6j337ldhckkgnwzp-adoptopenjdk-openj9-bin-8.0.212/jre': File exists
builder for '/nix/store/pfh4bljwpjq08wiy7cc90db04wsw9mmz-adoptopenjdk-openj9-bin-8.0.212.drv' failed with exit code 1

@risicle
Copy link
Contributor

risicle commented Jun 24, 2019

In fact more or less the same thing happens for adoptopenjdk-bin-8, along with a lot of downstream broken packages.

@denisgarci
Copy link

@risicle I'm having the same issue. Did you manage to fix it?

@risicle
Copy link
Contributor

risicle commented Sep 20, 2019

Sorry, no - I don't have access to a darwin machine full-time.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@Ekleog
Copy link
Member

Ekleog commented Feb 3, 2021

@gleber Do you still plan on working on this some day, or should this PR be closed? :)

@gleber
Copy link
Contributor Author

gleber commented Feb 3, 2021

Ah, not really. Closing.

@gleber gleber closed this Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gleber @risicle @denisgarci @Ekleog @ryantm