Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-inspect: init at 0.10.1 #63672

Merged
merged 1 commit into from Jul 7, 2019
Merged

cargo-inspect: init at 0.10.1 #63672

merged 1 commit into from Jul 7, 2019

Conversation

minijackson
Copy link
Member

Motivation for this change

Repo: https://github.com/mre/cargo-inspect

This tool is similar to cargo-expand but also print the desugared code.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xrelkd
Copy link
Contributor

xrelkd commented Jul 6, 2019

@GrahamcOfBorg build cargo-inspect

@xrelkd
Copy link
Contributor

xrelkd commented Jul 6, 2019

@GrahamcOfBorg build cargo-inspect
LGTM, tested locally on NixOS.
Hi @marsam, could you review this PR? Thank you!

@marsam marsam merged commit 1f2157d into NixOS:master Jul 7, 2019
@marsam
Copy link
Contributor

marsam commented Jul 7, 2019

Thanks!

@minijackson minijackson deleted the init-cargo-inspect branch September 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrelkd xrelkd xrelkd left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minijackson @xrelkd @marsam