cmake: 3.13.4 -> 3.14.5 #63704
Merged
cmake: 3.13.4 -> 3.14.5 #63704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttuegel
approved these changes
Jun 27, 2019
| version = "${majorVersion}.${minorVersion}"; | ||
| lib = stdenv.lib; | ||
| os = lib.optionalString; | ||
| version = "3.14.5"; |
There was a problem hiding this comment.
version and sha256 don't need to be up here anymore, right?
There was a problem hiding this comment.
right. I went ahead and removed the os shortcut as well.
|
Rebased on latest staging to fix the conflict. Should this be backported to 19.03? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://cmake.org/cmake/help/v3.14/release/3.14.html
Things done
Besides the updated version and Hash, I applied these changes to the expression:
with stdenv.libstatement to make the origin of various functions clearer at their call sites.Major.Minorfromversion, instead of the other way around. Hopefully making this package auto-updater friendly.sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)