Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: f49d8beff03e
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: d7752fc0ebf9
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jun 23, 2019

  1. buildGoPackage: keep string context (#63680) 

    In Nix, each string has a context that it carries of where it
originated. Some functions like filterAttrs modify the context of its
args when doing comparisons. That is important because we use the
string context of “name” to get where a derivation was defined. This
causes some builtins like unsafeGetAttrPos to report incorrectly that
the string was set in lib/attrsets.nix and reporting that as the
source file. Using removeAttrs avoids this problem.

Fixes #63679

(cherry picked from commit 1f46aaa)
The web list of packages shows the current stable branch, so we needed
to backport this to fix that effect soonish.  The change itself seems
very safe; only one rebuild is detected: `common-updater-scripts`
    @matthewbauer @vcunat
    matthewbauer authored and vcunat committed Jun 23, 2019
    Copy the full SHA
    d7752fc View commit details
    Browse the repository at this point in the history