Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elixir_1_9: init at 1.9.0 #63606

Merged
merged 4 commits into from Jul 3, 2019
Merged

elixir_1_9: init at 1.9.0 #63606

merged 4 commits into from Jul 3, 2019

Conversation

cw789
Copy link
Contributor

@cw789 cw789 commented Jun 21, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I just prepared this PR.
The use of C.UTF-8 instead of glibcLocales - en_US.UTF-8 needs to be tested if it doesn't have any side affects on Elixir.
Should only be merged when Elixir v1.9.0 is released, as I removed the then deprecated v1.4.

@ofborg ofborg bot requested a review from the-kenny June 21, 2019 09:26
@cw789 cw789 changed the title [WIP] elixir_1_9: init at 1.9.0-rc.0 elixir_1_9: init at 1.9.0 Jun 25, 2019
@cw789
Copy link
Contributor Author

cw789 commented Jun 25, 2019

On my side this is ready to merge now.
Will be my first real nixpkgs contribution.
I need to improve my contribution workflow for nixpkgs, but hope it won't be my last one.

Thx, for merging. All the best, Chris

@cw789
Copy link
Contributor Author

cw789 commented Jul 3, 2019

@the-kenny: Hello Moritz, can you help me to get this PR reviewed from your side?
Additionally how can I help to get this merged? Any other tests I should run ...

@LnL7
Copy link
Member

LnL7 commented Jul 3, 2019

@GrahamcOfBorg build elixir_1_9

LnL7
LnL7 approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit d215c18 into NixOS:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gleber gleber gleber left review comments

@LnL7 LnL7 LnL7 approved these changes

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
6.topic: erlang 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cw789 @LnL7 @gleber