Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cni-plugins: add version pin #63604

Merged
merged 1 commit into from Sep 22, 2019
Merged

cni-plugins: add version pin #63604

merged 1 commit into from Sep 22, 2019

Conversation

dingxiangfei2009
Copy link
Contributor

@dingxiangfei2009 dingxiangfei2009 commented Jun 21, 2019 •
edited

Motivation for this change

This PR adds a version pin to cni-plugins to allow sandboxed builds; and relaxes the constraint on the target platform, so that we can cross compile this package to, for example, aarch64 once #63603 is merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/kubernetes-on-arm-raspberry-pi/3182/2

@dingxiangfei2009
Copy link
Contributor Author

@cstrahan would you mind to review this pull request? :)

@cstrahan
Copy link
Contributor

@dingxiangfei2009 Thanks! Sorry, missed this until just now.

@cstrahan cstrahan merged commit 96bd4d2 into NixOS:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dingxiangfei2009 @nixos-discourse @cstrahan