Add NodeJS v10 to nixos-small channel #63605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v10 is the LTS but it is a breaking change to make it the default on 18.03 so it would be good to add it as build.
samueldr
requested changes
Jul 27, 2019
|
Argh! Should we revert on 18.03?
Wout.
…On Sat., Jul. 27, 2019, 9:27 p.m. Samuel Dionne-Riel < ***@***.***> wrote:
***@***.**** requested changes on this pull request.
This targets 18.03, which is not supported anymore, and wasn't for a while
when this PR was opened! Should this have targeted 19.03 instead?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#63605?email_source=notifications&email_token=AAANNFQS2IXYDA4CTXAE2LTQBSOSFA5CNFSM4H2PBSP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7YWVBI#pullrequestreview-267479685>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAANNFRJCNACEK7MVCGS543QBSOSFANCNFSM4H2PBSPQ>
.
|
|
I'm not sure I follow. Adding anything to the small release for 18.03 would be a no-op, since it was last updated 157 days ago, and will not (should not) receive any more updates. |
|
Closing as this targets the old release-18.03 brach which is not supported anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v10 is the LTS but it is a breaking change to make it the default on 18.03 so it would be good to add it as build.
This will increase the build time and closure size of nixos-small, but it would be useful for at least my servers.