Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf: remove 3.4 and 3.5 #63663

Closed
wants to merge 2 commits into from
Closed

protobuf: remove 3.4 and 3.5 #63663

wants to merge 2 commits into from

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Unless I missed something, protobuf 3.4 and 3.5 are not used in nixpkgs anymore and can be removed.

Things done

Remove protobuf 3.4 and 3.5.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lopsided98
protobuf: remove 3.4 and 3.5
1db6ee7 
They have no users in nixpkgs.
@lopsided98
Copy link
Contributor Author

I just added a commit that removes an obsolete compiler option, which only applied to GCC 6. The only reason this causes a rebuild is because the NIX_CFLAGS_COMPILE attribute was removed rather than being an empty string.

@Mic92
Copy link
Member

Mic92 commented Jun 23, 2019

Pushed to staging: 9702cd1 b14c3eb
because of the mass-rebuild.

@Mic92 Mic92 closed this Jun 23, 2019
@lopsided98 lopsided98 deleted the remove-old-protobuf branch June 23, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @Mic92