Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux_4_{14,19}: restore __kernel_fpu_{begin,restore} #63664

Merged
merged 2 commits into from Jun 22, 2019
Merged

linux_4_{14,19}: restore __kernel_fpu_{begin,restore} #63664

merged 2 commits into from Jun 22, 2019

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Jun 22, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tilpner
linux_4_14: restore __kernel_fpu_{begin,restore}
71b4b7b 
Linux commit 12209993e98c5fa1855c467f22a24e3d5b8be205 was backported to
4.14, so add the reverting patch to restore zfs performance.
@tilpner
linux_4_19: restore __kernel_fpu_{begin,restore}
0e6d0c1 
Linux commit 12209993e98c5fa1855c467f22a24e3d5b8be205 was backported to
4.19, so add the reverting patch to restore zfs performance.
@tilpner tilpner changed the title linxu_4_{14,19}: restore __kernel_fpu_{begin,restore} linux_4_{14,19}: restore __kernel_fpu_{begin,restore} Jun 22, 2019
@tilpner
Copy link
Member Author

tilpner commented Jun 22, 2019

Port to 19.03 in #63665

cc @Mic92

@tilpner
Copy link
Member Author

tilpner commented Jun 22, 2019

zfs noticed this a while ago: openzfs/zfs#8793 (comment)

@Mic92 Mic92 merged commit fd1acb6 into NixOS:master Jun 22, 2019
@tilpner tilpner mentioned this pull request Dec 2, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tilpner @Mic92