[UserTimingL3] Checking against malformed performance.measure options. #17427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 21, 2019
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1669643
branch
2 times, most recently
from
936fb56
to
f64844a
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1669643
branch
2 times, most recently
from
9d1ad35
to
7fc4299
Compare
In the User Timing L3 spec (https://w3c.github.io/user-timing/#measure-method), the performance.measure function can take an options dictionary as its second argument. If a non-empty dictionary is passed but neither of the 'start' nor 'end' members is present, a TypeError must be thrown. This change adds checks for this case and raises the appropriate errors. WPT coverage is also extended to check that user agents raise TypeErrors as specified. Change-Id: If47cf5803886cafb9dfab79c2cee1b6b572dbd3b Bug: 982385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669643 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#686949}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1669643
branch
from
7fc4299
to
56d035c
Compare
This was referenced Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the User Timing L3 spec
(https://w3c.github.io/user-timing/#measure-method), the
performance.measure function can take an options dictionary as its
second argument. If a non-empty dictionary is passed but neither of the
'start' nor 'end' members is present, a TypeError must be thrown.
This change adds checks for this case and raises the appropriate errors.
WPT coverage is also extended to check that user agents raise TypeErrors
as specified.
Change-Id: If47cf5803886cafb9dfab79c2cee1b6b572dbd3b
Bug: 982385
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669643
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686949}