Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yj: init at 4.0.0 #63621

Merged
merged 1 commit into from Jun 24, 2019
Merged

yj: init at 4.0.0 #63621

merged 1 commit into from Jun 24, 2019

Conversation

Profpatsch
Copy link
Member

Converter between json/yaml/toml (minimal wrapper around go libraries)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Profpatsch
Copy link
Member Author

@GrahamcOfBorg build yj

marsam
marsam requested changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like upstream uses go modules. Can you use buildGoModule?

@Profpatsch
Copy link
Member Author

Can you use buildGoModule?

I’d rather not, because it uses fixed output derivations.

@domenkozar
Copy link
Member

I wonder what it does if you have a heterogenous list in JSON and try to convert to TOML.

@Profpatsch
Copy link
Member Author

I wonder what it does if you have a heterogenous list in JSON and try to convert to TOML.

It only uses the golang default libraries, so you’ll have to defer to them. Probably something absurdly questionable.

@marsam ping

@marsam
Copy link
Contributor

marsam commented Jun 24, 2019

I’d rather not, because it uses fixed output derivations

No problem. I'm slightly inclined to buildGoModule because deps.nix it's a bit of a pain to maintain

@Profpatsch Profpatsch merged commit b041cff into NixOS:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Profpatsch @domenkozar @marsam