Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PythonPackages: add rig + sentinel #63729

Merged
merged 2 commits into from Jun 24, 2019
Merged

PythonPackages: add rig + sentinel #63729

merged 2 commits into from Jun 24, 2019

Conversation

timor
Copy link
Member

@timor timor commented Jun 24, 2019

Motivation for this change

Rig is a python module used in Neural Network research. Sentinel is a dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timor timor requested a review from FRidh as a code owner June 24, 2019 12:36
@Mic92 Mic92 merged commit 6e4633d into NixOS:master Jun 24, 2019
@timor
Copy link
Member Author

timor commented Jun 25, 2019

Can this be backported to 19.03?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timor @Mic92