Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gstreamer: re-enable auto_features #63637

Merged
merged 1 commit into from Jun 22, 2019
Merged

gstreamer: re-enable auto_features #63637

merged 1 commit into from Jun 22, 2019

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jun 21, 2019

Things done

/cc @jtojnar

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 21, 2019

Can you also move the libunwind back to isLinux section.
And drop it from legacy gstreamer.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 21, 2019

And also please use the proper gst_all_1.gstreamer commit tag so that borg can build it.

jtojnar
jtojnar approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this should do it.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 21, 2019

Let’s see if it fixes #63635

@GrahamcOfBorg build gst_all_1.gst-plugins-base

@LnL7
Copy link
Member Author

LnL7 commented Jun 21, 2019

That restores the linux hash to what it was before on master.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 21, 2019

While at it, could you also restore pkgs/development/libraries/gstreamer/legacy/gstreamer/default.nix?

@LnL7
Copy link
Member Author

LnL7 commented Jun 21, 2019

That fix works because it doesn't use meson to build.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 21, 2019

Is that needed though?

@ofborg ofborg bot requested review from ttuegel and matthewbauer June 21, 2019 23:24
@jtojnar
Copy link
Contributor

jtojnar commented Jun 22, 2019

It is not mentioned in the legacy gstreamer build log and is not part of its closure either.

vcunat
vcunat approved these changes Jun 22, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's fix this regression fast.

@vcunat vcunat mentioned this pull request Jun 22, 2019
Closed
@vcunat
Copy link
Member

vcunat commented Jun 22, 2019

The unwind for legacy doesn't seem critical, so I didn't want to wait for that.

@vcunat vcunat merged commit ce17e99 into NixOS:master Jun 22, 2019
vcunat added a commit that referenced this pull request Jun 22, 2019
@vcunat
Merge #63637: gst_all_1.gstreamer: re-enable auto_features
4260280 
In particular this fixes build of gst_all_1.gst-plugins-base
@LnL7 LnL7 deleted the darwin-gstreamer branch June 22, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@vcunat vcunat vcunat approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @jtojnar @vcunat