Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2019.06.08 -> 2019.06.21 [19.03] #63625

Merged
merged 1 commit into from Jun 21, 2019
Merged

youtube-dl: 2019.06.08 -> 2019.06.21 [19.03] #63625

merged 1 commit into from Jun 21, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jun 21, 2019 •
edited

Motivation for this change

Backport of #63624.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
youtube-dl: 2019.06.08 -> 2019.06.21
f30754e 
Fixes yet another youtube issue.

(cherry picked from commit d393963)
@timokau timokau merged commit ea18186 into NixOS:release-19.03 Jun 21, 2019
@timokau timokau deleted the youtube-dl-2019-06-21-19.03 branch June 21, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

@fpletz fpletz Awaiting requested review from fpletz

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@Phreedom Phreedom Awaiting requested review from Phreedom

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau