Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

megasync: init at 4.1.1.0 #63690

Merged
merged 3 commits into from Jun 25, 2019
Merged

megasync: init at 4.1.1.0 #63690

merged 3 commits into from Jun 25, 2019

Conversation

michojel
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@michojel
megasync: init at 4.1.1.0
5864dfb 
Signed-off-by: Michal Minář <mic.liamg@gmail.com>
@michojel
Copy link
Contributor Author

michojel commented Jun 23, 2019 •
edited

A continuation of #53126 (reverted in #55467)

@michojel
Copy link
Contributor Author

@ElXreno, @markuskowa, @matthewbauer, @NathanielHill PTAL

markuskowa
markuskowa requested changes Jun 23, 2019
View reviewed changes
pkgs/applications/misc/megasync/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/megasync/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/megasync/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/megasync/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/megasync/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/megasync/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/megasync/default.nix Outdated Show resolved Hide resolved
@michojel
addressed comments
6877159 
- ditched configurePhase and installPhase
- ffmpeg no longer optional

Signed-off-by: Michal Minář <mic.liamg@gmail.com>
@michojel
Copy link
Contributor Author

Thanks @markuskowa for the valuable feedback. Should be resolved now.

@markuskowa
Copy link
Member

markuskowa commented Jun 24, 2019 •
edited

@michojel you may also consider adding enableParallelBuilding = true to the derivation.
@GrahamcOfBorg build megasync

@michojel
reworked patches
a2585ff 
lincense free -> unfree
enabled parallel build

Signed-off-by: Michal Minář <mic.liamg@gmail.com>
@michojel
Copy link
Contributor Author

@michojel you may also consider adding enableParallelBuilding = true to the derivation.

Enabled. Thanks.

@markuskowa markuskowa merged commit cd83cec into NixOS:master Jun 25, 2019
michojel added a commit to michojel/NixOS that referenced this pull request Jun 25, 2019
@michojel
megasync: using upstream code now
2b5664c 
files copied from NixOS/nixpkgs#63690

Signed-off-by: Michal Minář <mic.liamg@gmail.com>
@michojel michojel mentioned this pull request Jul 5, 2019
Closed
@michojel michojel deleted the megasync branch August 8, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michojel @markuskowa