Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepin.dde-launcher: init at 4.6.13 #63675

Merged
merged 2 commits into from
Jun 26, 2019
Merged

deepin.dde-launcher: init at 4.6.13 #63675

merged 2 commits into from
Jun 26, 2019
+79 −0

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jun 22, 2019

Motivation for this change

Add dde-launcher, the launcher of Deepin Desktop Environment.

About packaging deepin for NixOS: #59023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 22, 2019
@romildo
Copy link
Contributor Author

romildo commented Jun 22, 2019

Tested on a virtual machine.

Screenshot from 2019-06-22 18-29-41

@romildo romildo requested a review from worldofpeace June 22, 2019 21:32
@romildo
Copy link
Contributor Author

romildo commented Jun 22, 2019

@GrahamcOfBorg build deepin.dde-launcher

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 22, 2019
worldofpeace
worldofpeace suggested changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few executables used with QProcess that we should hardcode.

@romildo
Copy link
Contributor Author

romildo commented Jun 24, 2019

There's a few executables used with QProcess that we should hardcode.

Done.

romildo added 2 commits June 26, 2019 00:40
@romildo
deepin.dde-launcher: init at 4.6.13

Unverified

The signing certificate or its chain could not be verified.
Certificate subject
CN Seth Vargo
emailAddress seth@sethvargo.com
Certificate issuer
CN SSL.com Client Certificate Intermediate CA RSA R2
O SSL Corp
Learn about vigilant mode
1d96489 
fixup! deepin.dde-launcher: init at 4.6.11

deepin.dde-launcher: 4.6.11 -> 4.6.12

deepin.dde-launcher: 4.6.12 -> 4.6.13
@romildo
nixos/deepin: add dde-launcher usb service

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b86c7b8
@romildo romildo changed the title deepin.dde-launcher: init at 4.6.11 deepin.dde-launcher: init at 4.6.13 Jun 26, 2019
@romildo romildo merged commit 40baa1f into NixOS:master Jun 26, 2019
@romildo romildo deleted the upd.deepin.dde-launcher branch June 26, 2019 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @worldofpeace