Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepin.dde-launcher: init at 4.6.13 #63675

Merged
merged 2 commits into from Jun 26, 2019
Merged

deepin.dde-launcher: init at 4.6.13 #63675

merged 2 commits into from Jun 26, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jun 22, 2019

Motivation for this change

Add dde-launcher, the launcher of Deepin Desktop Environment.

About packaging deepin for NixOS: #59023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
Copy link
Contributor Author

romildo commented Jun 22, 2019

Tested on a virtual machine.

Screenshot from 2019-06-22 18-29-41

@romildo
Copy link
Contributor Author

romildo commented Jun 22, 2019

@GrahamcOfBorg build deepin.dde-launcher

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few executables used with QProcess that we should hardcode.

pkgs/desktops/deepin/dde-launcher/default.nix Outdated Show resolved Hide resolved
@romildo
Copy link
Contributor Author

romildo commented Jun 24, 2019

There's a few executables used with QProcess that we should hardcode.

Done.

fixup! deepin.dde-launcher: init at 4.6.11

deepin.dde-launcher: 4.6.11 -> 4.6.12

deepin.dde-launcher: 4.6.12 -> 4.6.13
@romildo romildo changed the title deepin.dde-launcher: init at 4.6.11 deepin.dde-launcher: init at 4.6.13 Jun 26, 2019
@romildo romildo merged commit 40baa1f into NixOS:master Jun 26, 2019
@romildo romildo deleted the upd.deepin.dde-launcher branch June 26, 2019 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants