New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL_gpu: init at 20190124 #63608
SDL_gpu: init at 20190124 #63608
Conversation
@GrahamcOfBorg build SDL_gpu |
Anyone up for a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I have only done a cosmetic review so far but I'll look in more depth when I get a chance.
You did a great job. Just a few conventions I would recommend to follow. Thanks for your contribution.
@aanderse Thanks for the initial review. I've fixed those issues. |
@pmiddend Any time. Can you please give me an example of how you tested this? I tried to build the demos folder but ran into some issues. |
@aanders What I just did:
Now, this isn't an ideal test. Do you think that I should package the demos somehow? If so, I'd have to install the demos and the accompanying data folder. |
@pmiddend How would I go about compiling the following file?
Presumably you have a |
@aanderse My use-case is slightly more complex, as I use this library in a cython module (i.e. I'm not using it from C directly). However, the following derivation compiles the file you mentioned (assuming your local nixpkgs repo lies below
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmiddend Oh... I just assumed the package would install some pkgconfig
files or something. But no, you're just directly linking and including. OK.
@aanderse Yeah I'd have loved that, too, but the author just hasn't provided pkgbuild files (yet). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, no problem. Thanks for choosing to contribute to nixpkgs!
Motivation for this change
I'm using this package with SDL2.
Notes:
sed
command in thepatchPhase
. Replacing all of theOUTPUT_DIR
variables isn't necessary and would have broken the build as far as I can ascertain.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)