Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udev: change error message if RUN entry is not executable #63609

Merged
merged 2 commits into from Jun 24, 2019
Merged

udev: change error message if RUN entry is not executable #63609

merged 2 commits into from Jun 24, 2019

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Jun 21, 2019

Motivation for this change

The current error message leads to confusion as seen for example here (https://discourse.nixos.org/t/udev-extrarules-with-external-script/3229).
As the check explicitely checks if the entry is executable, it should be reflected in the error message.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/udev-extrarules-with-external-script/3229/4

@tokudan
Copy link
Contributor Author

tokudan commented Jun 21, 2019

I don't think there's any sensible tests apart from the generic installer test. Besides, it's only a string update. But let's try anyway...

@GrahamcOfBorg test installer

@matthewbauer matthewbauer merged commit 500c13e into NixOS:master Jun 24, 2019
@tokudan tokudan deleted the udev-executable-check branch June 24, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tokudan @nixos-discourse @matthewbauer