Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/bluetooth: don't install obex tools by default #63607

Merged
merged 2 commits into from Dec 1, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jun 21, 2019

Motivation for this change

Currently setting hardware.bluetooth.enable = true install the OpenOBEX tools along with bluez.
Since sharing files over bluetooth seems pretty uncommon and the packages are more than 200MB I propose we don't install them by default.


@worldofpeace
Copy link
Contributor

Only problem I see here could be like applications relying on obexftp being in the global environment and removing them would break them. (IIRC some plasma related utilities).

@worldofpeace
Copy link
Contributor

BlueZ still has obexd so this is more accurately removing the OpenOBEX related things.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 21, 2019

If we accept this, it needs to be mentioned in release notes.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 21, 2019

If we accept this, it needs to be mentioned in release notes.

Done.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 4, 2019

worldofpeace: do you know more about the plasma situation? If needed this could be installed behind a guard like plasma5.enable.

@worldofpeace
Copy link
Contributor

@rnhmjoj I'm not sure.

Perhaps some maintainers/contributors of plasma5 will know

@bkchr @ttuegel

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 29, 2019

I rebased and moved the note to 20.03. Any update?

@ttuegel
Copy link
Member

ttuegel commented Dec 1, 2019

If needed this could be installed behind a guard like plasma5.enable.

As far as I know this is still required by Plasma. Could you please put it behind a guard?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 1, 2019

Thank you @ttuegel. Is this ok?

@worldofpeace worldofpeace merged commit 15951cb into NixOS:master Dec 1, 2019
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks! 😃

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 3, 2019

Since sharing files over bluetooth seems pretty uncommon and the packages are more than 200MB I propose we don't install them by default.

@bjornfor are you aware of other desktop environments that need these tools?

@bjornfor
Copy link
Contributor

bjornfor commented Dec 3, 2019

No, I'm not aware of other DEs that need this. I was just worried there were, seeing that commit.

Since sharing files over bluetooth seems pretty uncommon

Personally, sharing files over bluetooth is something I would like to do, if it worked reliably. But I've never good enough experience with bluetooth on linux to rely on it :-/

@worldofpeace
Copy link
Contributor

I checked and it appears it's likely dolphin needed this for that functionality. So it probably won't be that a desktop environment needs, more that a program that uses this functionality will need the packages installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants