Skip to content

nixos/lidarr: allow specifying package #63726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

nixos/lidarr: allow specifying package #63726

merged 1 commit into from
Jun 27, 2019
+8 −1

Conversation

davidtwco
Copy link
Member

Motivation for this change

Allows users of services.lidarr to specify the package that is used with services.lidarr.package. The current version of lidarr in the 19.03 channel is too old to fetch from the lidarr.audio API, so this provides users an easy way to change to the unstable package if they wish.

cc @etu

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@davidtwco
nixos/lidarr: allow specifying package

Verified

This commit was signed with the committer’s verified signature.
davidtwco David Wood
GPG key ID: 2592E76C87381FD9
Verified
Learn about vigilant mode
7e38a64 
This commit allows users of `services.lidarr` to specify the package
that is used with `services.lidarr.package`.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 24, 2019
@etu etu merged commit dbb00bf into NixOS:master Jun 27, 2019
@davidtwco davidtwco deleted the lidarr/specify-package branch June 28, 2019 08:29
davidtwco added a commit to davidtwco/veritas that referenced this pull request Jul 1, 2019
@davidtwco
Use services.lidarr.package now that NixOS/nixpkgs#63726 landed.

Verified

This commit was signed with the committer’s verified signature.
davidtwco David Wood
GPG key ID: 2592E76C87381FD9
Verified
Learn about vigilant mode
9fab7e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidtwco @etu