Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubecfg: 0.9.1 -> 0.12.0 #63681

Merged
merged 1 commit into from Jun 26, 2019
Merged

kubecfg: 0.9.1 -> 0.12.0 #63681

merged 1 commit into from Jun 26, 2019

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Jun 23, 2019 •
edited

Motivation for this change

Update kubecfg: 0.9.1 -> 0.12.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh
FRidh reviewed Jun 23, 2019
View reviewed changes
pkgs/applications/networking/cluster/kubecfg/default.nix

buildGoPackage {
name = "kubecfg-${version}";

src = fetchFromGitHub {
owner = "ksonnet";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change owner? This is something worth mentioning in the commit message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ksonnet project was discontinued.
See: https://ksonnet.io/
and
vmware-archive/kubecfg#247

@groodt
Copy link
Contributor Author

groodt commented Jun 24, 2019

@FRidh Anything else that I should address?

@jonringer
Copy link
Contributor

$ nix-review pr 63681 passed
LGTM, but im not a golang guy

@groodt
Copy link
Contributor Author

groodt commented Jun 26, 2019

Ping @benley

@benley benley merged commit 6ea5cf3 into NixOS:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@benley benley benley approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@groodt @jonringer @benley @FRidh