Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distgen: init at 1.3 #63636

Merged
merged 1 commit into from Jul 12, 2019
Merged

distgen: init at 1.3 #63636

merged 1 commit into from Jul 12, 2019

Conversation

bachp
Copy link
Member

@bachp bachp commented Jun 21, 2019

Motivation for this change

This tool is mainly used in openshift to build source to image containers.
Building a source to image container required dg to be present.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we enable the unittests https://github.com/devexp-db/distgen/blob/master/Makefile#L9?

pkgs/development/tools/distgen/default.nix Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/tools/distgen/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

ping @bachp

@bachp
Copy link
Member Author

bachp commented Jul 11, 2019

@worldofpeace Thanks for reminding me.

I added the unit tests and they seem so to work.

The PR is updated to address all your change requests.

@bachp @worldofpeace
distgen: init at 1.3
195e30b 
This tool is mainly used in openshift to build source to image containers.
@worldofpeace
Copy link
Contributor

Force push put the testing dependencies in checkInputs.

worldofpeace
worldofpeace approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds for all interpreters and tests pass.

@worldofpeace worldofpeace merged commit f91c86d into NixOS:master Jul 12, 2019
@bachp bachp deleted the distgen branch July 12, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bachp @worldofpeace